Skip to content

[iOS] Fix modal page crash during app snapshot creation #31866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 3 commits into from
Nov 25, 2025
Merged

[iOS] Fix modal page crash during app snapshot creation #31866

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47a5cc7
Initial plan
Copilot Oct 4, 2025
a872744
Add null check in ControlsModalWrapper.ViewDidLayoutSubviews to preve…
Copilot Oct 4, 2025
b36e7e2
Add explanatory comment for defensive null check in ViewDidLayoutSubv…
Copilot Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Controls/src/Core/Platform/iOS/ControlsModalWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,13 @@ public override bool ShouldAutorotateToInterfaceOrientation(UIInterfaceOrientati
public override void ViewDidLayoutSubviews()
{
base.ViewDidLayoutSubviews();
_modal?.PlatformArrange(new Rect(0, 0, View!.Bounds.Width, View.Bounds.Height));

// Defensive check to prevent crashes during iOS snapshot creation
// when VirtualView may be disposed during app state transitions
if (_modal?.VirtualView is Page)
{
_modal?.PlatformArrange(new Rect(0, 0, View!.Bounds.Width, View.Bounds.Height));
}
}

public override void ViewWillAppear(bool animated)
Expand Down