[iOS] SearchHandler overlaps title and title view - fix #30772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/ios
community ✨
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the SearchHandler overlaps with the title and title view on iOS by properly managing the search controller's active state when editing stops. The fix ensures that when a user finishes editing the search bar, the search controller is properly deactivated to prevent visual overlap.
- Adds proper handling for search bar editing completion to deactivate the search controller
- Implements platform-specific logic for iOS 11+ vs earlier versions
- Ensures proper cleanup of event handlers to prevent memory leaks
| _searchHandlerAppearanceTracker.Dispose(); | ||
| _searchHandlerAppearanceTracker = null; | ||
|
|
||
| var searchBar = _searchController.SearchBar; |
There was a problem hiding this comment.
Consider adding a null check for _searchController before accessing SearchBar to prevent potential NullReferenceException during cleanup.
|
|
||
| var searchBar = _searchController.SearchBar; | ||
| searchBar.OnEditingStopped -= OnSearchBarEditingStopped; | ||
| searchBar.BookmarkButtonClicked -= BookmarkButtonClicked; |
There was a problem hiding this comment.
The BookmarkButtonClicked event handler is being unsubscribed in the cleanup method, but it was already being handled elsewhere in the existing code. This duplication could lead to attempting to unsubscribe an already unsubscribed handler.
Suggested change
| searchBar.BookmarkButtonClicked -= BookmarkButtonClicked; | |
| if (BookmarkButtonClicked != null) | |
| searchBar.BookmarkButtonClicked -= BookmarkButtonClicked; |
kubaflo
changed the title
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
fix-30771
branch
from
40e9687 to
57332e2
Compare
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
fix-30771
branch
from
57332e2 to
0a918ac
Compare
jsuarezruiz
reviewed
Oct 30, 2025
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
@kubaflo Could you rebase and fix the conflict?
Contributor
Author
done :) |
Member
|
/rebase |
github-actions
bot
force-pushed
the
fix-30771
branch
from
8c1f751 to
105792a
Compare
jfversluis
approved these changes
Dec 1, 2025
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Added a UI Test * Added snapshots * Handle SearchBar editing stopped event on iOS Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Added a UI Test * Added snapshots * Handle SearchBar editing stopped event on iOS Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Added a UI Test * Added snapshots * Handle SearchBar editing stopped event on iOS Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Added a UI Test * Added snapshots * Handle SearchBar editing stopped event on iOS Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Added a UI Test * Added snapshots * Handle SearchBar editing stopped event on iOS Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
* Added a UI Test * Added snapshots * Handle SearchBar editing stopped event on iOS Added support for the OnEditingStopped event on the SearchBar in ShellPageRendererTracker for iOS. This ensures the search controller is deactivated when editing stops and properly unsubscribes from the event during disposal to prevent memory leaks.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #30771
Screen.Recording.2025-07-23.at.02.02.14.mov
Screen.Recording.2025-07-23.at.02.00.50.mov