[iOS] Fix: ActivityIndicator IsRunning ignores IsVisible when set to true

[bhavanesh2001]

Description of Change

On iOS, the ActivityIndicator becomes visible even when IsVisible = false and IsRunning = true, effectively ignoring the IsVisible property.

Root Cause

Visibility is not being correctly mapped in iOS.

By default, IsVisible is true for all elements, so we must explicitly manage visibility based on the IsRunning value — especially since it's expected that the ActivityIndicator is hidden by default.

The current implementation seems to work because IsRunning defaults to false, which calls StopAnimating() and hides the native control. However, if HidesWhenStopped is set to false, the control remains visible without animating — which is incorrect.

To fix this, we explicitly update the visibility inside the IsRunning mapper, just as it's done on Android.

Before Fix	After Fix
before_fix.mov	after_fix.mov

Issues Fixed

Closes #28968

[bhavanesh2001]

  <VerticalStackLayout VerticalOptions="Center" HorizontalOptions="Center"> 
                <ActivityIndicator HorizontalOptions="Center" x:Name="busy"> 
                    <ActivityIndicator.Triggers>
                        <DataTrigger TargetType="ActivityIndicator" 
                            Binding="{Binding Source={x:Reference isRunningSwitch}, Path=IsToggled}" 
                            Value="True">
                             <Setter Property="IsRunning" Value="True" />
                        </DataTrigger>
                        <DataTrigger TargetType="ActivityIndicator" 
                            Binding="{Binding Source={x:Reference isVisibleSwitch}, Path=IsToggled}" 
                            Value="True"> 
                            <Setter Property="IsVisible" Value="True" /> 
                        </DataTrigger> 
                        <DataTrigger TargetType="ActivityIndicator" 
                            Binding="{Binding Source={x:Reference isRunningSwitch}, Path=IsToggled}" 
                            Value="False"> 
                            <Setter Property="IsRunning" Value="False" /> 
                        </DataTrigger> 
                        <DataTrigger TargetType="ActivityIndicator" 
                            Binding="{Binding Source={x:Reference isVisibleSwitch}, Path=IsToggled}" 
                            Value="False"> <Setter Property="IsVisible" Value="False" /> 
                        </DataTrigger> 
                    </ActivityIndicator.Triggers> 
                </ActivityIndicator> 
                <Switch x:Name="isRunningSwitch" HorizontalOptions="Center" /> 
                <Label Text="Toggle IsRunning" HorizontalOptions="Center" /> 
                <Switch x:Name="isVisibleSwitch" IsToggled="True" HorizontalOptions="Center" /> 
                <Label Text="Toggle IsVisible" HorizontalOptions="Center" />
</VerticalStackLayout>

[jsuarezruiz]

Could you include a Device Test for iOS checking the IsAnimating property of the UIActivityIndicatorView using the ActivityIndicator IsRunning and IsVisible properties? https://github.com/dotnet/maui/blob/ef1ec07908eda7b7bf9979fbbf9c374fbe7f2acf/src/Core/tests/DeviceTests/Handlers/ActivityIndicator/ActivityIndicatorHandlerTests.iOS.cs

[Domik234]

Thanks a lot for this PR!

I just wanted to ask if you also tried using HidesWhenStopped = false on construction to leave Hidden attribute control onto developer? I'm asking with regard to the need to call into Obj-C rather than using a managed object (I am not sure how costly is this process).

Thanks for your time. 😀

[bhavanesh2001]

@Domik234 As I mentioned. HidesWhenStopped = false will result in a visible activity indicator by default ,but it wont animate(wont spin). This is not expected.

[Domik234]

@bhavanesh2001 Sorry, I was hasty. I was re-reading if I didn't missed and before I was able to edit, you answered. 😀

[bhavanesh2001]

@jfversluis Could you run pipelines.

[jfversluis]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[bhavanesh2001]

Everything works as expected . But GetNativeIsRunning() seems to return true even when control is not visible. The UI test already covers this scenario.

Screen.Recording.2025-04-17.082414.mp4

[devanathan-vaithiyanathan]

@bhavanesh2001 , Adding the fix in the below places appears to resolve the issue with minimal code changes. Do you think more code changes are necessary?

[bhavanesh2001]

@bhavanesh2001 , Adding the fix in the below places appears to resolve the issue with minimal code changes. Do you think more code changes are necessary?

I think It's necessary to map and handle Visiibility like I did in the PR changes

#if __ANDROID__ || IOS || MACCATALYST
			// Since Visibility and IsRunning are dependent on each other, we handle Visibility explicitly.
			[nameof(IActivityIndicator.Visibility)] = MapIsRunning,
#endif

Based on the above changes, I think if I initialize the ActivityIndicator with IsVisible = false and IsRunning = true, and later change IsVisible to true, the indicator won't be shown (or it will be shown but wont animate)—even though at that point both IsVisible and IsRunning are true.

You can test and experiment with IsVisible and IsRunning using the sample code I included in the initial comments.

[devanathan-vaithiyanathan]

@bhavanesh2001 , Adding the fix in the below places appears to resolve the issue with minimal code changes. Do you think more code changes are necessary?

I think It's necessary to map and handle Visiibility like I did in the PR changes

#if __ANDROID__ || IOS || MACCATALYST
			// Since Visibility and IsRunning are dependent on each other, we handle Visibility explicitly.
			[nameof(IActivityIndicator.Visibility)] = MapIsRunning,
#endif

Based on the above changes, I think if I initialize the ActivityIndicator with IsVisible = false and IsRunning = true, and later change IsVisible to true, the indicator won't be shown (or it will be shown but wont animate)—even though at that point both IsVisible and IsRunning are true.

You can test and experiment with IsVisible and IsRunning using the sample code I included in the initial comments.

Yes @bhavanesh2001 , the mentioned scenario is working fine with my fix. The StartAnimate method is being called from the LayoutSubviews
Here is the demo video

ActivityIndicatorDemo.mov

[bhavanesh2001]

@devanathan-vaithiyanathan I think with my changes, we can remove the animation logic from LayoutSubviews. Also, I tried to follow the approach we're already using in the Android case. But feel free to open a PR with your changes as an alternative to this one, so the team can choose the approach they'd prefer to go with.

[bhavanesh2001]

/rebase

[jingo0]

@bhavanesh2001 Will this be addressed in .NET 9, or is it planned for .NET 10?

[bhavanesh2001]

@bhavanesh2001 Will this be addressed in .NET 9, or is it planned for .NET 10?

@jingo0 I'm not sure, But if you're facing an issue due to this, you can easily work your way around it.

You can bind IsVisible and IsEnabled to one property so that it hides and shows without any issues.

[jingo0]

@bhavanesh2001 Will this be addressed in .NET 9, or is it planned for .NET 10?

@jingo0 I'm not sure, But if you're facing an issue due to this, you can easily work your way around it.

You can bind IsVisible and IsEnabled to one property so that it hides and shows without any issues.

Binding IsRunning to IsVisible property did the trick. Surprisingly this issue only occurs on few Views!

[ghost]

Thanks for the patch — any update on merge status or further changes needed to get this landed? @jsuarezruiz @StephaneDelcroix

[development-jantar]

@jfversluis I think this is all done, just review is needed. Any chance this could be in next SR for MAUI?

[jfversluis]

/rebase