Entry Height gets updated when loaded inside the RoundRectangle Shape #25166

SuthiYuvaraj · 2024-10-10T06:08:00Z

RootCause

In the case of a rounded rectangle, the stroke thickness is added to the measured size during each Measure call. As a result, for every input in the Entry control, the width and height of the rounded rectangle are updated.

This issue was introduced due to the following PRs:
Rendering Shapes without explicit bounds. by VSadov · Pull Request #5817 · dotnet/maui (github.com)
Fixed Android RoundRectangle border logic by jstedfast · Pull Request #17087 · dotnet/maui (github.com)

While reverting change in above PR, current fix is fixed and issue mentioned above PR replicates.

Description of Change

The fix ensures that RoundRectangle handles stroke thickness consistently across measure calls. Previously, GetPath() directly used the full width and height without adjusting for StrokeThickness, causing the measured size to increase with each input event.

To resolve this, GetInnerPath() has been updated to exclude StrokeThickness from the size calculation, aligning RoundRectangle behavior with Rectangle. This prevents the height from increasing on each MeasureOverride() call.

Issues Fixed

Fixes #18092

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Output Videos

Before Issue Fix	After Issue Fix
18092_BeforeCahnges.mp4	18092_AfterChanges.mp4

jsuarezruiz · 2024-10-11T11:29:56Z

/azp run

azure-pipelines · 2024-10-11T11:30:17Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-10-21T15:09:24Z

/azp run

azure-pipelines · 2024-10-21T15:09:45Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-10-23T09:34:27Z

/rebase

jsuarezruiz · 2024-10-23T09:35:11Z

/azp run

azure-pipelines · 2024-10-23T09:35:31Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-10-25T00:54:22Z

/rebase

jsuarezruiz · 2024-10-25T10:14:59Z

/azp run

azure-pipelines · 2024-10-29T11:22:23Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-04T16:21:55Z

src/Controls/src/Core/Shapes/Shape.cs

 			// TODO: not using this.GetPath().Bounds.Size;
 			//       since default GetBoundsByFlattening(0.001) returns incorrect results for curves
-			RectF pathBounds = this.GetPath().GetBoundsByFlattening(1);
+			// Get the inner path by subtracting the stroke thickness for a rounded rectangle, as the GetPath() method returns the path including the stroke thickness.


A better approach would be to align the behavior between the RoundRectangle and the rest of the shapes.

@jsuarezruiz @PureWeen, The issue occurs specifically with RoundRectangle because its GetPath() method does not exclude StrokeThickness from width and height calculations. In contrast, other shapes like Rectangle and Ellipse already account for StrokeThickness in their GetPath() implementations.

For example, in Rectangle.cs, GetPath() subtracts StrokeThickness from both width and height before creating the path. However, in RoundRectangle.cs, GetPath() directly uses the full width and height without adjusting for StrokeThickness.

As a result, each MeasureOverride() call includes StrokeThickness in the size calculation, causing the height to increase on every input event for RoundRectangle. To align behavior across all shapes, I have updated the RoundRectangle implementation to exclude StrokeThickness from GetInnerPath(), ensuring consistency with Rectangle.cs.

What would happen if we just aligned the GetPath method of RoundRectangle to work like the GetPath of Rectangle and Ellipse?

The worry here is that we're creating an extra method that's purely for a special case scenario

@PureWeen The GetPath method of RoundRectangle was intentionally modified in a previous PR to remove any compensation for StrokeThickness, as the calling code now handles that separately. The PR description explicitly states that GetPath should use the width and height as-is, without adjustments for StrokeThickness.
To maintain consistency with the updated approach while still resolving the issue, I have applied the fix within GetInnerPath. This ensures that the behavior aligns with other shapes without altering GetPath, which has already been adjusted for a broader set of changes.

PureWeen

#25166 (comment)

jsuarezruiz

Could we align the behavior between all the shapes? #25166 (comment)

sheiksyedm · 2025-02-12T07:40:19Z

Could we align the behavior between all the shapes? #25166 (comment)

reply : #25166 (comment)

jsuarezruiz · 2025-02-26T07:52:16Z

/azp run

azure-pipelines · 2025-02-26T07:52:39Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-06-09T07:38:18Z

@SuthiYuvaraj Could you rebase? Thanks in advance.

jsuarezruiz · 2025-06-13T11:17:28Z

/azp run

azure-pipelines · 2025-06-13T11:17:52Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-07-15T12:11:49Z

/rebase

jsuarezruiz · 2025-07-15T12:14:25Z

/azp run

azure-pipelines · 2025-07-15T12:14:47Z

Azure Pipelines successfully started running 3 pipeline(s).

…#25166) * Fix commit for 18092 * Update Shape.cs * Commit for Maccatalyst * Update Shape.cs * Update Shape.cs * Commit for RoundRectangle change * commit name changes * Update Issue18092.xaml * Update Issue18092.xaml * Update Issue18092.xaml * Commit for method name

dotnet-policy-service bot added the community ✨ Community Contribution label Oct 10, 2024

SuthiYuvaraj marked this pull request as ready for review October 15, 2024 06:27

SuthiYuvaraj requested a review from a team as a code owner October 15, 2024 06:27

SuthiYuvaraj requested review from PureWeen and mattleibow October 15, 2024 06:27

SuthiYuvaraj marked this pull request as draft October 16, 2024 11:16

jsuarezruiz added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Oct 17, 2024

SuthiYuvaraj marked this pull request as ready for review October 18, 2024 07:58

github-actions bot force-pushed the fix-18092 branch from b8f7161 to fbc0cd2 Compare October 23, 2024 09:35

github-actions bot force-pushed the fix-18092 branch from fbc0cd2 to d16742e Compare October 25, 2024 00:55

This comment was marked as outdated.

Sign in to view

PureWeen added this to the .NET 9 Servicing milestone Oct 31, 2024

sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024

jsuarezruiz approved these changes Feb 4, 2025

View reviewed changes

jsuarezruiz reviewed Feb 4, 2025

View reviewed changes

PureWeen requested changes Feb 4, 2025

View reviewed changes

jsuarezruiz suggested changes Feb 4, 2025

View reviewed changes

SuthiYuvaraj force-pushed the fix-18092 branch from cc30354 to 3ad59bc Compare June 9, 2025 10:18

SuthiYuvaraj and others added 11 commits July 15, 2025 12:12

Fix commit for 18092

c137925

Update Shape.cs

a375928

Commit for Maccatalyst

ebfb8f3

Update Shape.cs

6657ab0

Update Shape.cs

fc7383c

Commit for RoundRectangle change

99e5c91

commit name changes

94a44c3

Update Issue18092.xaml

a3ecc3e

Update Issue18092.xaml

b1a9b5f

Update Issue18092.xaml

2f6bca8

Commit for method name

26649d2

github-actions bot force-pushed the fix-18092 branch from 3ad59bc to 26649d2 Compare July 15, 2025 12:12

StephaneDelcroix approved these changes Dec 3, 2025

View reviewed changes

StephaneDelcroix changed the base branch from main to inflight/current December 3, 2025 17:00

StephaneDelcroix merged commit 2cc27d8 into dotnet:inflight/current Dec 3, 2025
126 of 129 checks passed

github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Dec 3, 2025

Entry Height gets updated when loaded inside the RoundRectangle Shape #25166

Entry Height gets updated when loaded inside the RoundRectangle Shape #25166

Conversation

SuthiYuvaraj commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RootCause

Description of Change

Issues Fixed

Output Videos

Uh oh!

jsuarezruiz commented Oct 11, 2024

Uh oh!

azure-pipelines bot commented Oct 11, 2024

Uh oh!

PureWeen commented Oct 21, 2024

Uh oh!

azure-pipelines bot commented Oct 21, 2024

Uh oh!

jsuarezruiz commented Oct 23, 2024

Uh oh!

jsuarezruiz commented Oct 23, 2024

Uh oh!

azure-pipelines bot commented Oct 23, 2024

Uh oh!

PureWeen commented Oct 25, 2024

Uh oh!

jsuarezruiz commented Oct 25, 2024 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

azure-pipelines bot commented Oct 29, 2024

Uh oh!

jsuarezruiz Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

SuthiYuvaraj Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

PureWeen Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

SuthiYuvaraj Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

sheiksyedm commented Feb 12, 2025

Uh oh!

jsuarezruiz commented Feb 26, 2025

Uh oh!

azure-pipelines bot commented Feb 26, 2025

Uh oh!

jsuarezruiz commented Jun 9, 2025

Uh oh!

jsuarezruiz commented Jun 13, 2025

Uh oh!

azure-pipelines bot commented Jun 13, 2025

Uh oh!

jsuarezruiz commented Jul 15, 2025

Uh oh!

jsuarezruiz commented Jul 15, 2025

Uh oh!

azure-pipelines bot commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SuthiYuvaraj commented Oct 10, 2024 •

edited

Loading

jsuarezruiz commented Oct 25, 2024 •

edited by jfversluis

Loading