Skip to content

Implemented ios:Slider.UpdateOnTap #20124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfversluis merged 5 commits into from
Nov 26, 2025
Merged

Implemented ios:Slider.UpdateOnTap #20124

jfversluis merged 5 commits into from
Nov 26, 2025

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jan 24, 2024

Description of Change

I implemented the ios:Slider.UpdateOnTap property in the same way it has been implemented in Xamarin Forms

Issues Fixed

Fixes #20098

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-01-24.at.01.02.02.mp4

@kubaflo kubaflo requested a review from a team as a code owner January 24, 2024 00:04
@ghost ghost added the community ✨ Community Contribution label Jan 24, 2024
@ghost
Copy link

ghost commented Jan 24, 2024

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo mentioned this pull request Jan 24, 2024
Open
@samhouts samhouts added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jan 25, 2024
jsuarezruiz
jsuarezruiz reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a sample to allow check/test the platform specific here: https://github.com/dotnet/maui/tree/main/src/Controls/samples/Controls.Sample/Pages/PlatformSpecifics/iOS?

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 26, 2024

@jsuarezruiz sure I will do it later today

MartyIX
MartyIX reviewed Jan 26, 2024
View reviewed changes
@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 27, 2024

@jsuarezruiz the sample page has already been in the code https://github.com/dotnet/maui/blob/main/src/Controls/samples/Controls.Sample/Pages/PlatformSpecifics/iOS/iOSSliderUpdateOnTapPage.xaml

@Eilon Eilon added area-controls-slider Slider and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
PureWeen
PureWeen reviewed Jun 1, 2024
View reviewed changes
PureWeen
PureWeen requested changes Jun 1, 2024
View reviewed changes
@kubaflo kubaflo force-pushed the ios-slider-UpdateOnTap branch from 640aaf4 to b842bc7 Compare June 1, 2024 16:52
@kubaflo kubaflo requested a review from PureWeen June 1, 2024 16:53
@PureWeen
Copy link
Member

PureWeen commented Jun 2, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 2, 2024

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz previously approved these changes Jun 11, 2024
View reviewed changes
@Yves-Be
Copy link

Yves-Be commented Jun 19, 2024

This seems a bit wonky when using a centered Slider and a fixed width, I'm getting negative values that are being set.
<Slider Minimum="0" Maximum="100" WidthRequest="256" HeightRequest="64" HorizontalOptions="Center"/>

Perhaps something is still missing compared to Xamarin? tappedLocation.X now seems to be relative to the control frame already, so I don't think we need to subtract control.Frame.X

@kubaflo
Copy link
Contributor Author

kubaflo commented Jun 24, 2024

@Yves-Be you're absolutely right! Thank you yot pointing it out!

@kubaflo kubaflo self-assigned this Jun 24, 2024
@PureWeen
Copy link
Member

PureWeen commented Jul 16, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 16, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo kubaflo force-pushed the ios-slider-UpdateOnTap branch from 4175ce8 to 5a0e65a Compare August 31, 2024 23:44
@jingliancui

This comment was marked as off-topic.

Sign in to view
@PureWeen
Copy link
Member

PureWeen commented Aug 16, 2025

/rebase

@github-actions github-actions bot force-pushed the ios-slider-UpdateOnTap branch from 941a538 to 6caf573 Compare August 16, 2025 17:35
Copilot AI review requested due to automatic review settings August 16, 2025 17:35
Copilot AI reviewed Aug 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PureWeen
Copy link
Member

PureWeen commented Aug 16, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 16, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen modified the milestones: .NET 9 SR12, .NET 10 SR1 Sep 10, 2025
@PureWeen PureWeen modified the milestones: .NET 10 SR1, .NET 10.0 SR2 Nov 4, 2025
@jfversluis
Copy link
Member

jfversluis commented Nov 26, 2025

/rebase

@jfversluis jfversluis force-pushed the ios-slider-UpdateOnTap branch from 729d081 to e972161 Compare November 26, 2025 14:54
@jfversluis jfversluis changed the base branch from main to inflight/current November 26, 2025 14:54
@jfversluis jfversluis merged commit fd81cdb into dotnet:inflight/current Nov 26, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Nov 26, 2025
PureWeen pushed a commit that referenced this pull request Dec 3, 2025
@kubaflo @PureWeen
Implemented ios:Slider.UpdateOnTap (#20124)
82e4085 
Added a device test

Fixes

Fixed a memory leak

Don't interfere with other gestures
github-actions bot pushed a commit that referenced this pull request Dec 5, 2025
@kubaflo @PureWeen
Implemented ios:Slider.UpdateOnTap (#20124)
6a7bc65 
Added a device test

Fixes

Fixed a memory leak

Don't interfere with other gestures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattleibow mattleibow mattleibow left review comments

Copilot code review Copilot Copilot left review comments

@jfversluis jfversluis jfversluis approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 was automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen

+3 more reviewers

@MartyIX MartyIX MartyIX left review comments

@bhavanesh2001 bhavanesh2001 bhavanesh2001 left review comments

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kubaflo kubaflo

Labels

area-controls-slider Slider community ✨ Community Contribution platform/ios

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 10.0 SR2

Development

Successfully merging this pull request may close these issues.

iOS-specific Slider.UpdateOnTab doesn't work