Add null checks to SequenceEqual in System.Memory #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozkee
reviewed
Oct 2, 2025
Member
jozkee
left a comment
jozkee
left a comment
There was a problem hiding this comment.
- dotnet/coreclr#21232 was addressing null refs for more than just SequenceEqual, I think those will need to be addressed too.
- Can you please also include tests?
…or SequenceEqual NullReference scenario
…Update dataset expectations for some null reference scenarios where applicable in this repo.
tarekgh
reviewed
Oct 9, 2025
tarekgh
reviewed
Oct 9, 2025
tarekgh
reviewed
Oct 9, 2025
tarekgh
reviewed
Oct 9, 2025
Member
I see the rest is added. Only |
tarekgh
approved these changes
Oct 9, 2025
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
Added little comments/questions. LGTM, otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes @dotnet/runtime/issues/119901
Ports the null-checking logic for
SpanHelpers<T>.SequenceEqualfrom the core runtime implementation to the System.Memory package, ensuring correct handling of nullable reference types and preventingNullReferenceExceptionwhen comparing arrays with nulls.