Update package description for SDS #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
approved these changes
Apr 23, 2025
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. There's precedence with two other proj files:
Contributor
|
After we publish a new release, you'll have to submit a new PR to turn the package off and bump the versions manually. We intend to have a script and a bot that would do that automatically for us once a package is published, but it's not ready yet: #222 |
Member
I think we - the owners of this repo - should be doing that. |
David-Engel
approved these changes
Apr 23, 2025
saurabh500
reviewed
May 1, 2025
| <AssemblyVersion>4.6.1.6</AssemblyVersion> <!-- NO-INCREMENT: This version is frozen for .NET Standard and .NETCoreApp because the assembly ships inbox. --> | ||
| <NoWarn>$(NoWarn);CA1001;CA1068;CA1069;CA1309;CA1310;CA1419;CA1510;CA1711;CA1805;CA1806;CA1816;CA1822;CA1830;CA1834;CA1835;CA1836;CA1840;CA1844;CA1852;CA1853;CA1854;CA1859;CA1863;CA2016;CA2020;CA2101;CA2200;CA2201;CA2208;CA2219;CA2249;CA2251;CA5366;CS0168;CS0618;CS0649;CS0672;IDE0073;SYSLIB0004;SYSLIB0051;nullable;</NoWarn> | ||
| <EnableDefaultCompileItems>false</EnableDefaultCompileItems> | ||
| <PackageDescription>System.Data.SqlClient is deprecated. Please use Microsoft.Data.SqlClient instead.</PackageDescription> |
Contributor
There was a problem hiding this comment.
How about a stronger call to action
DEPRECATED - Please use Microsoft.Data.SqlClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.