Turn off packages and bump versions #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
commented
Mar 24, 2025
Contributor
Author
There was a problem hiding this comment.
Questions.
In the readme I documented that we should always bump Baseline, but maybe there are exceptions I should document? https://github.com/dotnet/maintenance-packages?tab=readme-ov-file#how-to-migrate-a-library
src/System.Reflection.DispatchProxy/src/System.Reflection.DispatchProxy.csproj
Show resolved
Hide resolved
src/System.Threading.Tasks.Extensions/src/System.Threading.Tasks.Extensions.csproj
Show resolved
Hide resolved
ViktorHofer
approved these changes
Mar 25, 2025
Member
|
Yes, baseline should always be bumped. I had to downgrade the version for the three packages that we unlisted because they caused ApiCompat issues in regards to the version. Your changes look good and bring the basepine versions in sync again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ost recent versions in nuget.org are:
This was done manually. I have an issue open to track the work to automate these PRs: #217