Fix ValueTuple consumption on >= net471 #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System.ValueTuple is inbox on .NET Framework >= 4.7.1 and therefore any potential redirect for it should be removed. This is necessary as the assembly version in the already shipped packages is higher than what's provided inbox on .NET Framework
ericstj
reviewed
Mar 19, 2025
Co-authored-by: Eric StJohn <[email protected]>
ericstj
reviewed
Mar 19, 2025
ericstj
approved these changes
Mar 19, 2025
|
This fix broke net471+ apps that consumed community libraries targeting net462 that referenced System.ValueTuple 4.5.0: #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
System.ValueTuple is inbox on .NET Framework >= 4.7.1 and therefore any potential redirect for it should be removed. This is necessary as the assembly version in the already shipped packages is higher than what's provided inbox on .NET Framework
Package layout: