Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 19, 2025

Fixes #212

  • Remove netcoreapp placeholders when there's already a .NET Standard placeholder.
  • Mark libraries as packable
  • Simplify placeholder conditions
  • Add a placeholder for dispatchproxy netcoreapp2.0 and netstandard2.1 and remove type forwards.

@ViktorHofer ViktorHofer requested review from a team and stephentoub as code owners March 19, 2025 09:58
Fixes #212

- Remove netcoreapp placeholders when there's already a .NET Standard placeholder.
- Mark libraries as packable
- Simplify placeholder conditions
- Make dispatchproxy a placeholder for netcoreapp2.0 and netstandard2.1 and remove type forwards.
@ViktorHofer ViktorHofer force-pushed the FixPackagesForNetStandard21 branch from 347a048 to f7a429f Compare March 19, 2025 10:16
@ViktorHofer ViktorHofer requested review from a team as code owners March 19, 2025 10:16
@ViktorHofer
Copy link
Member Author

My sample application now passes with these changes when targeting netstandard2.1, netstanard2.0 and net462:

PS C:\temp\memory> dotnet build /bl
Restore complete (0.6s)
You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
  memory netstandard2.1 succeeded (0.8s) → bin\Debug\netstandard2.1\memory.dll
  memory net462 succeeded (0.9s) → bin\Debug\net462\memory.dll
  memory netstandard2.0 succeeded (0.9s) → bin\Debug\netstandard2.0\memory.dll

The _HandlePackageFileConflict task doesn't report any conflicts anymore.

@ViktorHofer ViktorHofer reopened this Mar 19, 2025
@ViktorHofer ViktorHofer requested review from carlossanlop and ericstj and removed request for a team and stephentoub March 19, 2025 10:43
@ViktorHofer ViktorHofer requested a review from a team as a code owner March 19, 2025 17:04
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in a call with Viktor and confirmed the results are correct in conflict resolution.

  • IsPackable enabled in the assemblies that need republishing.
  • VersionPrefix not changed, that number was bumped in my last PR.
  • AssemblyVersions, TargetFrameworks and their conditions modified as required, confirmed in the manual tests in the call.

@ViktorHofer ViktorHofer merged commit 21a1320 into main Mar 19, 2025
5 checks passed
@ViktorHofer ViktorHofer deleted the FixPackagesForNetStandard21 branch March 19, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The type ... exists in both ... and 'netstandard, Version=2.1.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

3 participants