-
Notifications
You must be signed in to change notification settings - Fork 11
Add netstandard2.1 placeholders #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #212 - Remove netcoreapp placeholders when there's already a .NET Standard placeholder. - Mark libraries as packable - Simplify placeholder conditions - Make dispatchproxy a placeholder for netcoreapp2.0 and netstandard2.1 and remove type forwards.
347a048 to
f7a429f
Compare
Member
Author
|
My sample application now passes with these changes when targeting netstandard2.1, netstanard2.0 and net462: The _HandlePackageFileConflict task doesn't report any conflicts anymore. |
carlossanlop
approved these changes
Mar 19, 2025
Contributor
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in a call with Viktor and confirmed the results are correct in conflict resolution.
- IsPackable enabled in the assemblies that need republishing.
- VersionPrefix not changed, that number was bumped in my last PR.
- AssemblyVersions, TargetFrameworks and their conditions modified as required, confirmed in the manual tests in the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212