-
Notifications
You must be signed in to change notification settings - Fork 11
Add new build target to show error if package is not being updated but its dependencies are #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itive service packages and then another target that consumes those transitive service packages and print an error if the current project is not set to ship but its dependencies are.
…jects that have IsPackable set to FALSE and are source projects only.
…odified TargetPathWithTargetPlatformMoniker so that that the IsPackable property is appended, as it is needed in the newly added targets.
…others, and disable building the packages that depend on them.
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
reviewed
Mar 6, 2025
ViktorHofer
approved these changes
Mar 6, 2025
ericstj
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
Follow up of #207 (comment)
Similar to what we have in runtime, we want to throw an error whenever we need to update a package because one of its dependencies is getting updated.
Opened as draft because I added a temporary commit that enables building some packages that are dependencies of others, and disabled building packages that consume those dependencies, to prove the change works. The output in my local machine is: