-
Notifications
You must be signed in to change notification settings - Fork 406
Add the host support to the PowerShell kernel #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Microsoft.DotNet.Interactive.Jupyter.Tests/ExecuteRequestHandlerTests.cs
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostRawUserInterface.cs
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/Progress/ProgressPane.cs
Outdated
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostRawUserInterface.cs
Outdated
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterface.cs
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterfaceProgress.cs
Outdated
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterfaceProgress.cs
Outdated
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterfacePrompt.cs
Outdated
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterfacePrompt.cs
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterfacePrompt.cs
Show resolved
Hide resolved
Microsoft.DotNet.Interactive.PowerShell/Host/Progress/PendingProgress.cs
Outdated
Show resolved
Hide resolved
@daxian-dbw Where do we craft |
@TylerLeonhardt |
@TylerLeonhardt It used to be taken care of by individual kernel, but @jonsequitur made a change recently to take care of that in general for all kernels, the relevant code is here: interactive/Microsoft.DotNet.Interactive/KernelBase.cs Lines 76 to 91 in 5bce463
|
Nice. That change flew under my radar. Thanks! |
2dcb1a6
to
980d04f
Compare
@TylerLeonhardt Your comments are addressed. Can you please take another look when you get a chance? |
Microsoft.DotNet.Interactive.PowerShell/Host/PSKernelHostUserInterfaceProgress.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, otherwise LGTM - it's pretty wild how much code needs to brought in to truly host PowerShell. I wish we could do something about that but I'm not really sure what.
Thanks @TylerLeonhardt! |
@daxian-dbw any idea if this will work with native executables that accept input/password? Like |
Rebased to resolve conflicts. |
I had a offline discussion with @jonsequitur and @colombod about the concern on the test coverage. |
Rebased the changes to resolve conflict. |
Thanks @jonsequitur! I will get #219 done ASAP. |
Thanks to you @daxian-dbw! This is great stuff. |
Fix #190
Fix #159
Implement the PowerShell host interfaces for the PowerShell kernel, so as to provide a rich interactive experience to the PS kernel.
The light-up features are:
Write-Host
with foreground/background color, and properly deal with-NoNewLine
;Read-Host
andGet-Credential
;The rich experience is shown as below: