-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Port documentation for .NET 7.0 Preview2 #7889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f403e1a
a46279e
b9e0711
ed68b26
9a71172
e0fb2e5
007d98d
901086b
e236e2a
7b63399
b52ba44
b1b2bda
92802bf
41436c5
34fc34d
a73cf72
983d213
d9e3998
ebb3d27
e6c12ef
6b9fd7f
12dacd2
8e88b82
b500534
1139b2f
a41ce85
01cfbe3
4dce592
837f031
9cdc64d
35682e3
19711be
72e9a27
3887d09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -175,7 +175,7 @@ | |
</Parameters> | ||
<Docs> | ||
<param name="other">To be added.</param> | ||
<summary>To be added.</summary> | ||
<summary>Infrastructure support to make this a first class struct</summary> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like an old change, but I'm not sure why we're capturing it just now. @gewarren did this assembly exist before in dotnet-api-docs? Also, @dotnet/area-system-componentmodel can you please provide a more meaningful summary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see there have been some recent modifications to the file, even though most of the @stephentoub are we ok with keeping that summary? |
||
<returns>To be added.</returns> | ||
<remarks>To be added.</remarks> | ||
</Docs> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is different because it's an extension method. So is this more accurate?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/area-system-collections thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any specific guidance for the
this
extension method parameter in the writing guidelines wiki. It just seems weird to refer to it as "the specified elements" when in most cases, you aren't really "specifying" them. You're calling a method on them.Anyway, I don't think this is super important, so I'm fine if you want to leave it as-is.