Skip to content

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Aug 6, 2024

Some APIs were missed in the previous PR.

Contributes to dotnet/runtime#105979

@carlossanlop carlossanlop requested review from a team and gewarren August 6, 2024 22:33
@carlossanlop carlossanlop self-assigned this Aug 6, 2024
@carlossanlop carlossanlop requested a review from a team as a code owner August 6, 2024 22:33
@ghost ghost added the area-System.IO label Aug 6, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io

@learn-build-service-prod

This comment was marked as outdated.

@jozkee
Copy link
Member

jozkee commented Aug 7, 2024

@adegeo @dotnet/docs for overloads using the new params ReadOnlySpan<T> language feature, they should render as params, not as scoped I believe:
image

cc @stephentoub

@carlossanlop carlossanlop requested review from adegeo and jozkee August 7, 2024 19:46
@carlossanlop
Copy link
Contributor Author

@adegeo @dotnet/docs for overloads using the new params ReadOnlySpan<T> language feature, they should render as params, not as scoped I believe:

I opened a bug for the Docs Dev Team: https://dev.azure.com/ceapex/Engineering/_workitems/edit/989732

cc @gewarren

@learn-build-service-prod

This comment was marked as outdated.

@carlossanlop
Copy link
Contributor Author

The NFloat failure is unrelated to this PR, I'm fixing it here: #10211 (comment)

@carlossanlop carlossanlop requested a review from jozkee August 9, 2024 19:50
@learn-build-service-prod

This comment was marked as outdated.

@carlossanlop carlossanlop enabled auto-merge (squash) August 12, 2024 18:49
@learn-build-service-prod
Copy link

Learn Build status updates of commit d6aa03a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/File.xml ✅Succeeded View
xml/System.IO/Path.xml ✅Succeeded View
xml/System.IO/StreamWriter.xml ✅Succeeded View
xml/System.IO/TextWriter.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit 60b5435 into dotnet:main Aug 12, 2024
@carlossanlop carlossanlop deleted the PortSystemIO branch August 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants