Skip to content

Add preview 4 breaking change #46587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Add preview 4 breaking change #46587

merged 2 commits into from
Jun 6, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jun 6, 2025

@gewarren gewarren requested a review from a team as a code owner June 6, 2025 02:32
@dotnetrepoman dotnetrepoman bot added this to the June 2025 milestone Jun 6, 2025
@gewarren gewarren requested review from Copilot, a team and Nigusu-Allehu and removed request for a team June 6, 2025 02:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds and registers the new Preview 4 breaking change for dotnet package list, refines the table formatting in several TOC files, updates the main .NET 10 breaking changes page with the new entry and a current date, and tweaks one prompt file’s wording.

  • Introduces dotnet package list restore behavior doc and injects it into the TOC.
  • Fixes HTTP warnings TOC text, normalizes table separators, and updates ms.date.
  • Adjusts .github/prompts/breaking-change.md to refine its issue‐label wording.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
docs/core/compatibility/toc.yml Added new entries and revised existing TOC items; reformatted separators.
docs/core/compatibility/sdk/10.0/dotnet-package-list-restore.md New breaking-change document outlining implicit restore behavior.
docs/core/compatibility/10.0.md Updated ms.date and added the new CLI restore row in the summary.
.github/prompts/breaking-change.md Refined prompt language around "breaking-change" issues.
Comments suppressed due to low confidence (3)

docs/core/compatibility/toc.yml:73

  • [nitpick] The TOC entry lost backticks around the commands, making it unclear that it refers to dotnet package list and dotnet package search. Consider adding backticks for clarity and consistency.
              - name: HTTP warnings promoted to errors in package list and search

docs/core/compatibility/sdk/10.0/dotnet-package-list-restore.md:2

  • [nitpick] For consistency with other CLI breaking change titles, consider including .NET CLI in the title (e.g., .NET CLI dotnet package list command now performs restore by default).
title: "Breaking change - dotnet package list command now performs restore by default"

docs/core/compatibility/sdk/10.0/dotnet-package-list-restore.md:37

  • [nitpick] It may be helpful to include an explicit example of the full command usage (for example, dotnet package list --no-restore) to guide users.
- Use the `--no-restore` option with `dotnet package list` if you want to bypass the implicit restore step.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit d8520a6 into dotnet:main Jun 6, 2025
8 checks passed
@gewarren gewarren deleted the list-restore branch June 6, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking change]: dotnet package list command behavior change
2 participants