Skip to content

Fix the dash typo in lang flag of classlib in Unit testing Visual Basic page #46481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented May 29, 2025

This pull request fixes #46461 by correcting mistakes reported in the issue:

  • removes a dash typo from the -lang option
  • adds the -lang option to two dotnet new xunit calls
    By default, this command creates the C# project, but this page is about the VB, hence adding this -lang option to make sure VB project is created seems logical.

Internal previews

📄 File 🔗 Preview link
docs/core/testing/unit-testing-visual-basic-with-xunit.md Unit testing Visual Basic .NET Core libraries using dotnet test and xUnit

@BartoszKlonowski BartoszKlonowski requested review from IEvangelist and a team as code owners May 29, 2025 14:26
@dotnetrepoman dotnetrepoman bot added this to the May 2025 milestone May 29, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels May 29, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BartoszKlonowski

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) May 30, 2025 12:16
@BillWagner BillWagner merged commit 293b396 into dotnet:main May 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect syntax given in example
2 participants