Add slnx extension option #45106
Merged
Add slnx extension option #45106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Mar 4, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @gewarren
I had one suggestion, and then let's 
| * A single project by specifying the *project.json* file to migrate. | ||
| * All of the directories specified in the *global.json* file by passing in a path to the *global.json* file. | ||
| * A *solution.sln* file, where it migrates the projects referenced in the solution. | ||
| * A *solution.sln(x)* file, where it migrates the projects referenced in the solution. |
There was a problem hiding this comment.
I think this change is wrong. The dotnet migrate command was removed in .NET Core 3.0 SDK, and I don't believe the slnx parsing was backported to any older SDKs, so there is no .NET SDK version that can parse slnx in dotnet migrate.
Contributor
Author
There was a problem hiding this comment.
Ahh, good catch, I'll revert. Thanks @KalleOlaviNiemitalo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal previews