Skip to content

Fixed wrong comment in code snippet Indices And Ranges #40672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tymtam2
Copy link
Contributor

@tymtam2 tymtam2 commented Apr 30, 2024

Summary

Fixed wrong code comment introduced by #40607 in one of the snippets for Indices And Ranges.

dotnet run
==========          Starting Index and Range Samples.          ==========
          ==========          Last Index.            ==========
The last word is < tenth >.
          ==========          Range.                 ==========
< second >< third >< fourth >                                                                   <---- fixed this comment
          ==========          Last Range.            ==========
< ninth >< tenth >
          ==========          Partial Range.         ==========
< first >< second >< third >< fourth >< fifth >< sixth >< seventh >< eighth >< ninth >< tenth >
< first >< second >< third >< fourth >
< seventh >< eighth >< ninth >< tenth >
          ==========          Index and Range types. ==========
< eighth >
< second >< third >< fourth >

@tymtam2 tymtam2 requested a review from BillWagner as a code owner April 30, 2024 02:29
@dotnet-bot dotnet-bot added this to the April 2024 milestone Apr 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Apr 30, 2024
@tymtam2
Copy link
Contributor Author

tymtam2 commented Apr 30, 2024

BTW. I created a PR with this fix right after the original #40607 was merged and I wondered why it's not being merged. Only today I looked at the PR and it was to main in my fork. Doh!

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @tymtam2

I'll :shipit: now.

@BillWagner BillWagner merged commit 3fc786d into dotnet:main Apr 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc fundamentals/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants