Minor clean up and switch to Bearer token header #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Since the
tokenparameter in the .ctor is assigned from theOspoKeyenvironment variable value, we'd need to ensure that consuming GitHub Action workflows are updated to get a request token, similar to the following flow:This would need to happen before calling into quest, so that the
OspoKeyis assigned from the returnedTOKEN. The main question we'd need answered is, where do we get these values, I'm assuming Jeff Wilcox would know:secrets.CLIENT_IDsecrets.TENANT_IDsecrets.OSMP_API_AUDIENCE