This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix SocketsHttpHandler handling of pooling timeouts with max connections #29822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two cases: 1. When a pooling timeout (lifetime or idle) is set to 0, we fail to enforce the MaxConnectionsPerServer limit. 2. When MaxConnectionsPerServer is set and the limit is reached, when a request completes and we transfer the connection from the completing request to a waiting request, we fail to check / enforce the connection lifetime limit.
davidsh
reviewed
May 21, 2018
| connection.Trace( | ||
| receivedUnexpectedData ? "Disposing connection returned to pool. Read-ahead unexpectedly completed." : | ||
| _disposed ? "Disposing connection returned to pool. Pool was disposed." : | ||
| "Disposing connection returned to pool. Zero idle timeout."); |
Contributor
There was a problem hiding this comment.
nit: Remove double spaces after period in these last two logging strings.
davidsh
approved these changes
May 21, 2018
Member
Author
|
@dotnet-bot test Outerloop Windows x64 Debug Build please |
5 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ons (dotnet/corefx#29822) * Fix SocketsHttpHandler handling of pooling timeouts with max connections Fixes two cases: 1. When a pooling timeout (lifetime or idle) is set to 0, we fail to enforce the MaxConnectionsPerServer limit. 2. When MaxConnectionsPerServer is set and the limit is reached, when a request completes and we transfer the connection from the completing request to a waiting request, we fail to check / enforce the connection lifetime limit. * Address PR feedback Commit migrated from dotnet/corefx@50e3011
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two cases:
Fixes https://github.com/dotnet/corefx/issues/29397
Fixes https://github.com/dotnet/corefx/issues/29410
cc: @geoffkizer, @davidsh