Skip to content

Conversation

@martincostello
Copy link
Collaborator

Fix permissions missed from #3528.

Fix permissions missed from #3528.
Copilot AI review requested due to automatic review settings August 12, 2025 14:31
@martincostello martincostello added github_actions Pull requests that update GitHub Actions code bug fix labels Aug 12, 2025
@martincostello martincostello enabled auto-merge (rebase) August 12, 2025 14:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the permissions configuration in the GitHub Actions workflow file to fix permissions that were missed from a previous change (referenced as #3528). The change moves permissions from the global workflow level to the job level and adds additional permission scopes.

  • Removes global workflow permissions and sets them to an empty object
  • Adds job-specific permissions with broader scope including actions, contents, and security-events

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (be07a45) to head (6bc7097).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3529   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files         110      110           
  Lines        3816     3816           
  Branches      722      722           
=======================================
  Hits         3598     3598           
  Misses        218      218           
Flag Coverage Δ
Linux 94.28% <ø> (ø)
Windows 94.28% <ø> (ø)
macOS 94.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello merged commit 9f9ba05 into master Aug 12, 2025
14 checks passed
@martincostello martincostello deleted the fix-zizmor-permissions branch August 12, 2025 14:35
This was referenced Aug 27, 2025
This was referenced Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants