Skip to content

Make sure dolt_tests system table changes show up in dolt diff by default #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timsehn merged 2 commits into from
Sep 2, 2025
Merged

Make sure dolt_tests system table changes show up in dolt diff by default #9773

timsehn merged 2 commits into from
Sep 2, 2025

Conversation

@timsehn
Copy link
Contributor

@timsehn timsehn commented Sep 2, 2025

Addresses: #9771

macneale4
macneale4 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes with that skip in the middle of the test removed, LGTM.

@timsehn timsehn linked an issue Sep 2, 2025 that may be closed by this pull request
dolt_tests system table does not show in dolt diff #9771
Closed
@timsehn timsehn changed the title Make sure dolt_tests changes show up in dolt diff by default Make sure dolt_tests system table changes show up in dolt diff by default Sep 2, 2025
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Sep 2, 2025

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b87ebff ok 5937471
version total_tests
b87ebff 5937471
correctness_percentage
100.0

@timsehn timsehn merged commit 291e512 into main Sep 2, 2025
23 of 25 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macneale4 macneale4 macneale4 approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dolt_tests system table does not show in dolt diff

4 participants

@timsehn @coffeegoddd @macneale4