Skip to content

Conversation

@reltuk
Copy link
Contributor

@reltuk reltuk commented Sep 2, 2025

We install the statically built ICU4C packages into the sysroots before building.

We pass icu_static as a build tag.

We add CXX support to the Cgo build.

We bump build image to Debian trixie (newer MinGW is necessary) and we pick up cross tools which have built for that base image.

We add -static-libgcc and -static-libstdc++ to the Windows build, as necessary.

…e release build script to use ICU4C-enabled toolchains.

We install the statically built ICU4C packages into the sysroots before building.

We pass icu_static as a build tag.

We add CXX support to the Cgo build.

We bump build image to Debian trixie (newer MinGW is necessary) and we pick up cross tools which have built for that base image.

We add -static-libgcc and -static-libstdc++ to the Windows build, as necessary.
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
159d406 ok 5937471
version total_tests
159d406 5937471
correctness_percentage
100.0

…d tag and flags for darwin target to get libc++ as C++ stdlib.
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
238c7d4 ok 5937471
version total_tests
238c7d4 5937471
correctness_percentage
100.0

Copy link
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit 3dad0f7 into main Sep 11, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants