Skip to content

Cache materialized commits on doltdb #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jycor merged 5 commits into from
Sep 2, 2025
Merged

Cache materialized commits on doltdb #9757

jycor merged 5 commits into from
Sep 2, 2025

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Aug 30, 2025 •
edited
Loading

Changes:

  • store a cache of all resolved commit hashes on doltdb

This results in another ~2.3x speed up, so ~4.7x in total.

@coffeegoddd
Copy link
Contributor

coffeegoddd commented Aug 30, 2025

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1e663e6 ok 5937471
version total_tests
1e663e6 5937471
correctness_percentage
100.0

@jycor jycor changed the title try caching in ddb Cache materialized commits on doltdb Sep 2, 2025
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Sep 2, 2025

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5098342 ok 5937471
version total_tests
5098342 5937471
correctness_percentage
100.0

fulghum
fulghum reviewed Sep 2, 2025
View reviewed changes
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Sep 2, 2025

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
adbed9c ok 5937471
version total_tests
adbed9c 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

coffeegoddd commented Sep 2, 2025

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1ac2f70 ok 5937471
version total_tests
1ac2f70 5937471
correctness_percentage
100.0

fulghum
fulghum approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jycor jycor merged commit d4924e7 into main Sep 2, 2025
24 of 26 checks passed
@jycor jycor deleted the james/commit-cache branch September 2, 2025 22:38
@BrewTestBot BrewTestBot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fulghum fulghum fulghum approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jycor @coffeegoddd @fulghum