-
-
Notifications
You must be signed in to change notification settings - Fork 596
go: cmd/dolt: sql.go: Enable Auto GC when running dolt sql.
#9726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'dolt sql' do not currently run auto GC.
This allows things like bulk imports of mysqldumps to take advantage of auto-gc. In this change, this setting is not currently configurable. It may represent a performance regression for some workloads.
Contributor
Contributor
|
@coffeegoddd DOLT
|
…hutdown and a database hook still gets called.
Contributor
zachmu
approved these changes
Aug 29, 2025
Member
zachmu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting those typos in there so I could add value
Co-authored-by: Zach Musgrave <[email protected]>
Co-authored-by: Zach Musgrave <[email protected]>
Contributor
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During something like an mysqldump import, Dolt disk utilization can be unexpectedly high if we do run GC. This change enables Auto GC by default when running
dolt sqlin local mode.Auto GC can be optionally disabled by passing the
--disable-auto-gcflag to thedolt sqlinvocation.Auto GC behavior for
dolt sql-serveris not changed. It is still enabled through theconfig.yamlfile, and is off by default.