Skip to content

[no-release-notes] Remove redundant beginTableCalled variable #10202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elianddb merged 1 commit into from
Dec 11, 2025
Merged

[no-release-notes] Remove redundant beginTableCalled variable #10202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions go/cmd/dolt/commands/diff_filter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,7 @@ func TestLazyRowWriter_NoRowsWritten(t *testing.T) {
mockDW := &mockDiffWriter{}
realWriter := &mockRowWriter{}

beginTableCalled := false
onFirstWrite := func() error {
beginTableCalled = true
return mockDW.BeginTable("fromTable", "toTable", false, false)
}

Expand All @@ -417,7 +415,7 @@ func TestLazyRowWriter_NoRowsWritten(t *testing.T) {
}

// BeginTable should NEVER have been called
if beginTableCalled {
if mockDW.beginTableCalled {
t.Error("BeginTable() was called even though no rows were written - should have been lazy!")
}
}
Expand Down
Loading