-
-
Notifications
You must be signed in to change notification settings - Fork 596
dolthub/dolt#10136: Fix dolt_backup to work in non-Dolt directories
#10164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dolt_backup to work in non-Dolt directories.dolt_backup to work in non-Dolt directories
macneale4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good from the perspective of testing and the features behavior.
I think you may want to ship this as it's own change. As discussed in DM, the abstractions for determining when it's ok to not have a physical dolt database as a file accessible entity are busted. Fixing that would be greatly appreciated.
Fixes #10136
dolt_backupto work in non-Dolt directories; this amends thedolt.goboolean expression for commands that accept non-Dolt directories into a searchable map.sql-backup.batsfromlocal-remote.bashso it also gets run against server.