Skip to content

Conversation

@angelamayxie
Copy link
Contributor

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8f6b47c ok 5937471
version total_tests
8f6b47c 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6d94494 ok 5937471
version total_tests
6d94494 5937471
correctness_percentage
100.0

@angelamayxie angelamayxie changed the title Update datetime type to datetime3 for dolt tables Update datetime type to datetime3 for dolt system tables Dec 3, 2025
@coffeegoddd
Copy link
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
36b7fbc ok 5937471
version total_tests
36b7fbc 5937471
correctness_percentage
100.0

@angelamayxie angelamayxie changed the title Update datetime type to datetime3 for dolt system tables Update datetime types to correct precision for dolt system tables Dec 4, 2025
@coffeegoddd
Copy link
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e896f35 ok 5937471
version total_tests
e896f35 5937471
correctness_percentage
100.0

@angelamayxie angelamayxie marked this pull request as ready for review December 4, 2025 23:09
@angelamayxie angelamayxie requested a review from jycor December 4, 2025 23:09
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@angelamayxie DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ca02be3 ok 5937471
version total_tests
ca02be3 5937471
correctness_percentage
100.0

@angelamayxie angelamayxie merged commit f73ec2d into main Dec 4, 2025
23 of 26 checks passed
@angelamayxie angelamayxie deleted the angela/datetime branch December 4, 2025 23:58
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 2
batching batch sql 10000 1 0.08 1.63
batching by line sql 10000 1 0.07 1.86
blob 1 blob 200000 1 0.91 4.14 4.4
blob 2 blobs 200000 1 0.87 4.76 4.75
blob no blob 200000 1 0.9 2.79 2.73
col type datetime 200000 1 0.85 2.55 2.69
col type varchar 200000 1 0.67 3.84 3.73
config width 2 cols 200000 1 0.79 2.68 2.72
config width 32 cols 200000 1 1.89 2.86 2.64
config width 8 cols 200000 1 0.99 2.75 2.79
pk type float 200000 1 0.86 2.53 2.56
pk type int 200000 1 0.83 2.53 2.58
pk type varchar 200000 1 1.49 1.77 1.69
row count 1.6mm 1600000 1 5.55 3.11 3.15
row count 400k 400000 1 1.45 2.93 2.93
row count 800k 800000 1 2.81 3.04 3.1
secondary index four index 200000 1 3.7 1.32 1.16
secondary index no secondary 200000 1 0.88 2.84 2.75
secondary index one index 200000 1 1.16 2.55 2.4
secondary index two index 200000 1 2.02 1.8 1.78
sorting shuffled 1mm 1000000 0 5.37 2.86 2.74
sorting sorted 1mm 1000000 1 5.45 2.8 2.72

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.18
dolt_blame_commit_filter system table 2.6
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.72
dolt_diff_log_join_to_commit system table 2.82
dolt_diff_table_from_commit_filter system table 1.18
dolt_diff_table_to_commit_filter system table 1.28
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.52
dolt_log_commit_filter system table 1.1

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.65
adds_updates_deletes 60000 60000 60000 3.27
deletes_only 0 60000 0 1.68
updates_only 0 0 60000 2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DATETIME values with microseconds are not comparable unless the literal includes the hidden fractional seconds

4 participants