Skip to content

dolthub/dolt#10138: Fix dolt_backup sync and sync-url not taking working set changes in transaction #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elianddb merged 2 commits into from
Dec 2, 2025
Merged

dolthub/dolt#10138: Fix dolt_backup sync and sync-url not taking working set changes in transaction #10147

elianddb merged 2 commits into from
Dec 2, 2025

Conversation

@elianddb
Copy link
Contributor

@elianddb elianddb commented Dec 2, 2025

Fixes #10138

@elianddb elianddb mentioned this pull request Dec 2, 2025
Closed
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Dec 2, 2025

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
235d97d ok 5937471
version total_tests
235d97d 5937471
correctness_percentage
100.0

@elianddb elianddb changed the title dolthub/dolt#10138: Fix dolt_backup sync and sync-url not working in transaction dolthub/dolt#10138: Fix dolt_backup sync and sync-url not taking working set changes in transaction. Dec 2, 2025
@elianddb elianddb changed the title dolthub/dolt#10138: Fix dolt_backup sync and sync-url not taking working set changes in transaction. dolthub/dolt#10138: Fix dolt_backup sync and sync-url not taking working set changes in transaction Dec 2, 2025
@coffeegoddd
Copy link
Contributor

coffeegoddd commented Dec 2, 2025

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d4d6dc0 ok 5937471
version total_tests
d4d6dc0 5937471
correctness_percentage
100.0

@macneale4 macneale4 self-requested a review December 2, 2025 19:17
@elianddb elianddb marked this pull request as ready for review December 2, 2025 19:22
macneale4
macneale4 approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requested, but it doesn't require another review.

@coffeegoddd
Copy link
Contributor

coffeegoddd commented Dec 2, 2025

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4231e7a ok 5937471
version total_tests
4231e7a 5937471
correctness_percentage
100.0

@elianddb elianddb merged commit aae600a into main Dec 2, 2025
23 of 25 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macneale4 macneale4 macneale4 approved these changes

Assignees

No one assigned

Labels

correctness_approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is dolt_add("-A") Required Before Calling the Stored Procedure dolt_backup("sync", "name")?

4 participants

@elianddb @coffeegoddd @macneale4