Skip to content

Install additional gems #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2017

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Aug 3, 2017

Users can install additional gems using Gemfile.local and/or
plugins/*/{Gemfile,PluginGemfile}.

@@ -101,6 +101,8 @@ case "$1" in

# ensure the right database adapter is active in the Gemfile.lock
cp "Gemfile.lock.${adapter}" Gemfile.lock
# ensure to install additional gems for Gemfile.local and plugins
bundle echeck || bundle install --without development test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any reference to bundle echeck, but I did find bundle check (https://bundler.io/v1.15/man/bundle-check.1.html); was this perhaps a typo?

This seems generally sane, given that we no longer invoke bundle install (#80), and given that it's conditional on whether it's actually deemed necessary.

I think these are also currently indented with spaces, and need to be indented with tabs instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is typo. I've fixed and force pushed.

Users can install additional gems using Gemfile.local and/or
plugins/*/{Gemfile,PluginGemfile}.
@okkez okkez force-pushed the install-additional-gems branch from 71ecb27 to e2e01f9 Compare August 3, 2017 23:59
@tianon tianon merged commit 843b0d7 into docker-library:master Aug 4, 2017
@tianon
Copy link
Member

tianon commented Aug 4, 2017

Thanks!

tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 7, 2017
- `nextcloud`: 10.0.6, 11.0.4, 12.0.1; redis 3.1.3 (nextcloud/docker#138)
- `openjdk`: debian `9~b181-1`
- `redmine`: `bundle install` if necessary (docker-library/redmine#84)
- `ruby`: add `stretch` (docker-library/ruby#144), add `alpine3.6` (docker-library/ruby#145)
@zx1986
Copy link

zx1986 commented Aug 17, 2017

It seems Gemfile.local or plugins/*/{Gemfile,PluginGemfile} not work for me :-(

Here is my docker-compose.yml:

projects:
  image: redmine:3-passenger
  container_name: projects
  restart: always
  ports:
    - "3000:3000"
  volumes:
    - ./config/database.yml:/usr/src/redmine/config/database.yml
    - ./config/configuration.yml:/usr/src/redmine/config/configuration.yml
    - ./public/themes:/usr/src/redmine/public/themes
    - ./plugins:/usr/src/redmine/plugins
    - ./files:/usr/src/redmine/files
    - ./log:/usr/src/redmine/log
  env_file:
    - docker.env

Where should I put my Gemfile.local into?

@okkez okkez deleted the install-additional-gems branch August 17, 2017 02:16
@zx1986
Copy link

zx1986 commented Aug 17, 2017

https://github.com/docker-library/redmine/blob/master/3.4/docker-entrypoint.sh#L103

I think I should mount a Gemfile.lock.production into container?
But it didn't make sense ...
How about these plugins/*/Gemfile?

@zx1986
Copy link

zx1986 commented Aug 17, 2017

And I didn't get this:
https://github.com/docker-library/redmine/blob/master/3.4/Dockerfile#L79

Seems Gemfile.lock.${adapter} is copy from Gemfile.lock (which is the Redmine's original Gemfile.lock), so what is the best practices I add my own / plugins gems into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants