-
Notifications
You must be signed in to change notification settings - Fork 174
Install additional gems #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3.1/docker-entrypoint.sh
Outdated
@@ -101,6 +101,8 @@ case "$1" in | |||
|
|||
# ensure the right database adapter is active in the Gemfile.lock | |||
cp "Gemfile.lock.${adapter}" Gemfile.lock | |||
# ensure to install additional gems for Gemfile.local and plugins | |||
bundle echeck || bundle install --without development test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any reference to bundle echeck
, but I did find bundle check
(https://bundler.io/v1.15/man/bundle-check.1.html); was this perhaps a typo?
This seems generally sane, given that we no longer invoke bundle install
(#80), and given that it's conditional on whether it's actually deemed necessary.
I think these are also currently indented with spaces, and need to be indented with tabs instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is typo. I've fixed and force pushed.
Users can install additional gems using Gemfile.local and/or plugins/*/{Gemfile,PluginGemfile}.
71ecb27
to
e2e01f9
Compare
Thanks! |
- `nextcloud`: 10.0.6, 11.0.4, 12.0.1; redis 3.1.3 (nextcloud/docker#138) - `openjdk`: debian `9~b181-1` - `redmine`: `bundle install` if necessary (docker-library/redmine#84) - `ruby`: add `stretch` (docker-library/ruby#144), add `alpine3.6` (docker-library/ruby#145)
It seems Gemfile.local or plugins/*/{Gemfile,PluginGemfile} not work for me :-( Here is my docker-compose.yml:
Where should I put my Gemfile.local into? |
https://github.com/docker-library/redmine/blob/master/3.4/docker-entrypoint.sh#L103 I think I should mount a Gemfile.lock.production into container? |
And I didn't get this: Seems Gemfile.lock.${adapter} is copy from Gemfile.lock (which is the Redmine's original Gemfile.lock), so what is the best practices I add my own / plugins gems into that? |
Users can install additional gems using Gemfile.local and/or
plugins/*/{Gemfile,PluginGemfile}.