Skip to content

Put "docker-entrypoint.sh" into PATH and allow it to run Cassandra when given no arguments #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

tianon
Copy link
Member

@tianon tianon commented Jan 3, 2018

This also includes our standard backwards compatibility symlink which will automatically be removed for 3.12 and above.

@tianon
Copy link
Member Author

tianon commented Jan 3, 2018

$ ./update.sh
2.1: 2.1.19
2.2: 2.2.11
3.0: 3.0.15
3.11: 3.11.1

@yosifkit yosifkit merged commit 524bc1a into docker-library:master Jan 3, 2018
@yosifkit yosifkit deleted the entrypoint-in-path branch January 3, 2018 00:24
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jan 3, 2018
- `cassandra`: add `docker-entrypoint.sh` to PATH (docker-library/cassandra#130)
- `ghost`: 1.19.1
- `haproxy`: 1.6.14, 1.7.10
- `nextcloud`: redis-3.1.6, APCu-5.1.9
- `php`: better libs-preserving code (docker-library/php#556)
- `redmine`: add `sqlserver` database adapter (docker-library/redmine#100)
- `rocket.chat`: 0.60.3
- `wordpress`: remove `-dev` dependencies (docker-library/wordpress#267)
@CSdread
Copy link

CSdread commented Jan 29, 2018

This is for retrospective for you guys, we use 2.2.11 as our upstream container for a custom Cassandra cluster. This PR broke our cluster due to the fact that we have a custom docker-entrypoint.sh that we loaded into /. We have come to expect that a docker image with a specific tag will have stability which allows us to build on top of it. We would propose a build version on the image tag to prevent retro-active updating of a docker images affecting production systems.

@yosifkit @tianon

@tianon
Copy link
Member Author

tianon commented Jan 29, 2018

@CSdread sorry to hear this caused issues 😞

Honestly though, what I'd recommend in that situation is that instead of COPYing over the top of our file and expecting ENTRYPOINT to stay consistent, simply copy your file elsewhere (since you've already paid the storage cost for our script, however minimal) and use ENTRYPOINT in your sub-Dockerfile to point it at your script instead. That also allows you do do things like start up a shell from your descendant image and use diff to compare your entrypoint script to the image-provided one, and allows you to pipe your entrypoint to ours if necessary if you want both behaviors chained together (ie, set something like ENTRYPOINT ["/custom-entrypoint.sh", "/docker-entrypoint.sh"]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants