Reduce Token expiry delta and add get_token retries #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python SDK states that the delta should be capped at 30s and the Go SDK uses 0s.
djc
reviewed
Jun 6, 2023
Owner
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Please apply suggestions across all three implementations of the retry loops. ;)
src/custom_service_account.rs
Outdated
| tracing::debug!("requesting token from service account: {:?}", request); | ||
| let res = client.request(request).await; | ||
| match res { | ||
| Ok(res) => break Ok(res), |
Owner
There was a problem hiding this comment.
You're using res both for result and response here. Would be nice to disambiguate (I like using rsp for response, but just response might work, too).
Contributor
Author
There was a problem hiding this comment.
Decided for response to be more explicit because it's returned by the loop and might not be immediately clear to the reader.
Owner
There was a problem hiding this comment.
Can we do the same inside the match here?
(Also -- sorry for noticing it only now -- given the break Ok() perhaps we can deindent the loop tail by one step out of the match?)
The official SDKs implement a retry mechanism for fetching the tokens from the metadata server in the case of I/O errors, etc. This adds a similar mechanism to the provided ServiceAccount implementations
This release includes a retry mechanism for fetching tokens for service accounts, and reduces the expiry delta for tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles some smaller issues.
First, other, official, SDKs use smaller values than 30s. The Python SDK uses 20s, and the Go SDK uses 0s for credentials from the metadata server.
This PR reduces the delta to 20s, following the Python SDK.
Second, the official SDKs use a retry mechanism for fetching tokens from the various backends.
This PR adds a retry of at most 5 requests for each fetch token request.
This also bumps the version to 0.8.1. The changes above are internal only and thus are semver compatible for a patch release.