Default token expiry #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Feb 24, 2023
djc
reviewed
Feb 26, 2023
djc
reviewed
Feb 27, 2023
…ey are tightly coupled
djc
reviewed
Mar 13, 2023
Owner
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Sorry -- a few more nits, I'm pretty sure this is the last round!
djc
approved these changes
Mar 14, 2023
Owner
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks for persisting through this review cycle!
Author
|
@djc It's no trouble at all - thank you for the rigorous review! I appreciate the commitment to quality. This is the first time I've submitted to an open-source project, so I'm excited to have done it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
GCloudAuthorizedUser::from_stringdefaults the token'sexpiry_timetoNone, which causesToken::has_expiredto always return false. This results inAuthenticationManager::get_tokennever refreshing a token that was retrieved via aGCloudAuthorizedUser. I have refactoredInnerTokento store expiry time as anOffsetDateTimeinstead of anOption<OffsetDateTime>, and that will default to 1 hour in the future (3600 seconds).