Skip to content

use tokio-runtime instead of tokio-native #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 1 commit into from
Nov 11, 2022
Merged

use tokio-runtime instead of tokio-native #60

djc merged 1 commit into from
Nov 11, 2022

Conversation

@henriiik
Copy link
Contributor

@henriiik henriiik commented Nov 11, 2022

Hello!

This PR switches the switches the native-tokio feature flag to tokio-runtime for hyper-rustls.

The native-tokio feature flag implies tokio-runtime and rustls-native-certs which makes it impossible to remove the rustls-native-certs by setting default-features = false on gcp_auth

https://github.com/rustls/hyper-rustls/blob/5a923eca42e6b68e66a40735b868481ac519e54d/Cargo.toml#L34

djc
djc approved these changes Nov 11, 2022
View reviewed changes
Copy link
Owner

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@djc djc merged commit 73c4a2c into djc:master Nov 11, 2022
@henriiik
Copy link
Contributor Author

henriiik commented Nov 11, 2022

Thanks for the quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henriiik @djc