Make token cheap to clone #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts the token inside an Arc'ed inner, making clones cheaper. Because ServiceAccounts clone the token every time they give it out this adds up when using enough tokes per minute. The tests were written before the changes to token to ensure their (de)serialising behaviour stayed the same.
flub
pushed a commit
to getsentry/symbolicator
that referenced
this pull request
Dec 10, 2021
This should only be temporary until upstream has made a release with what we need. In the mean time this allows us to benefit from a few improvements: - Cheaper token clones (djc/gcp_auth#43 already on upstream master, not released) - No thundering herds when refreshing the tokens: djc/gcp_auth#41
flub
pushed a commit
to getsentry/symbolicator
that referenced
this pull request
Dec 13, 2021
This should only be temporary until upstream has made a release with what we need. In the mean time this allows us to benefit from a few improvements: - Cheaper token clones (djc/gcp_auth#43 already on upstream master, not released) - No thundering herds when refreshing the tokens: djc/gcp_auth#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts the token inside an Arc'ed inner, making clones cheaper.
Because ServiceAccounts clone the token every time they give it out
this adds up when using enough tokes per second.
The tests were written before the changes to token to ensure
their (de)serialising behaviour stayed the same.