Use gcloud.cmd to invoke gcloud on Windows
#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the name of the `gcloud` command is `gcloud.cmd`, while on MacOS and Linux the name is just `gcloud`. While on the Windows Command prompt invoking `gcloud` works, this is not the case when a process is spawned with Rust's `Command`, causing the application to fail to execute the command. As a solution, we introduce an OS specific variable reflecting the actual command name for each OS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the name of the
gcloudcommand isgcloud.cmd, while on MacOS and Linux the name is justgcloud.While on the Windows Command prompt invoking
gcloudworks, this is not the case when a process is spawned with Rust'sCommand, causing the application to fail to execute the command.As a solution, we introduce an OS specific variable reflecting the actual command name for each OS.
Closes #111