Simplify API #108
Merged
Simplify API #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings are still denied in CI.
flokli
added a commit
to flokli/bigtable_rs
that referenced
this pull request
Jul 1, 2024
gcp_auth changed their AuthenticationManager API in djc/gcp_auth#108. gcp_auth::provider() now returns a Arc<dyn TokenProvider>, rather than a AuthenticationManager, and AuthenticationManager is gone. This updates references in bigtable_rs codebase to follow.
flokli
added a commit
to flokli/bigtable_rs
that referenced
this pull request
Jul 1, 2024
gcp_auth changed their AuthenticationManager API in djc/gcp_auth#108. gcp_auth::provider() now returns a Arc<dyn TokenProvider>, rather than a AuthenticationManager, and AuthenticationManager is gone. This updates references in bigtable_rs codebase to follow. Closes liufuyang#75.
liufuyang
pushed a commit
to liufuyang/bigtable_rs
that referenced
this pull request
Jul 1, 2024
* chore: bump arduino/setup-protoc GH action The version of protoc used in v1 doesn't seem to exist anymore, as can be seen by a failing CI run: https://github.com/liufuyang/bigtable_rs/actions/runs/9357260352/job/25756593924 ``` Run arduino/setup-protoc@v1 Getting protoc version: v3.20.3 Downloading archive: https://github.com/protocolbuffers/protobuf/releases/download/v3.20.3/protoc-3.20.3-osx-aarch_64.zip Error: Error: Failed to download version v3.20.3: Error, Unexpected HTTP response: 404 - 404 ``` * chore: bump gcp_auth to 0.12.2 gcp_auth changed their AuthenticationManager API in djc/gcp_auth#108. gcp_auth::provider() now returns a Arc<dyn TokenProvider>, rather than a AuthenticationManager, and AuthenticationManager is gone. This updates references in bigtable_rs codebase to follow. Closes #75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.