DEV: Add compatibility with the Glimmer Post Stream #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the user notes plugin by splitting logic into multiple files, introducing value transformers, and adopting Glimmer components. Added a new setting `user_notes_icon_placement` to control icon placement (options: `name` or `avatar`). [skip ci]
- Added functionality to display user notes count based on `user_custom_fields`. - Updated `PostMetadataUserNotes` component to dynamically toggle between emoji or icon based on site settings. - Refactored logic for rendering the user notes icon in different UI contexts (mobile and desktop). - Removed hard-coded version constraint for `withPluginApi`
Extracted the logic for updating the `user_notes_count` field into a new `updatePostUserNotesCount` function. Updated all related components and initializers to use this function, reducing duplication and ensuring consistency in handling user notes updates.
tyb-talks
approved these changes
Jun 25, 2025
Added a new compatibility entry for Discourse version 3.5.0.beta8-dev to ensure proper version tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the discourse-user-notes plugin to ensure compatibility with the new Glimmer-based Post Stream in Discourse. The changes include: