[TechDebt: Issue #321] Upgrade to Go 1.16 #322
Merged
+17
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install gorelease via go install as opposed to via the curl command which is no longer supported
dikhan
force-pushed
the
feature/upgrade-go-1.16
branch
from
1bbfc05 to
67e17da
Compare
dikhan
force-pushed
the
feature/upgrade-go-1.16
branch
from
e5e565a to
ae03d87
Compare
- This test really needs to run against a local test server where we don't rely on any external endpoint (which is bad) but fixing it for now with the regex until a proper fix is added.
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 60 60
Lines 3591 3591
=======================================
Hits 3360 3360
Misses 163 163
Partials 68 68 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this Pull Request solve?
Please link to the issue number here (issue will be closed when PR is merged): Closes #321
Type of change
What type of change does your code introduce to the provider? Please put an
x(w/o heading/trailing white spaces) in the boxes that apply:Checklist
Please put an
x(w/o heading/trailing white spaces) in the boxes that apply:make test-all[FeatureRequest: Issue #X] <PR Title>[BugFix: Issue #X] <PR Title>[TechDebt: Issue #X] <PR Title>[NewRelease] vX.Y.ZChecklist for Admins