feat: add isUserIdentifier in SelectPicker and add abortSignal in getClusterOptions #948
+51
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces enhancements to the SelectPicker component suite, focusing on improved support for user identifier options and minor improvements in API utility. The primary change is the introduction of an
isUserIdentifierprop, enabling custom rendering (including avatars or icons) for options that represent user identifiers, such as API tokens. Additionally, there is a small update to the cluster options API utility to support request cancellation.SelectPicker user identifier support:
isUserIdentifierprop toSelectPicker,FilterSelectPicker, and their respective prop types, enabling special rendering for options that represent user identifiers. [1] [2] [3] [4]SelectPickerOptionto display an avatar or icon for user identifier options, and to extract and display the username for API tokens. [1] [2]isUserIdentifierprop is properly passed through all relevant components and used as a dependency in memoized callbacks. [1] [2] [3]isUserIdentifierusage to multi-select mode only.Utility and import improvements:
common.tsxto includegetAlphabetIconandAPI_TOKEN_PREFIXfor rendering and parsing user identifier options.API utility update:
getClusterOptionsto accept an optionalAbortSignal, allowing for request cancellation.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist