Modified docs to adhere to schema_2nd PR #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsony
requested changes
Mar 5, 2021
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
maysunfaisal
requested changes
Mar 15, 2021
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
elsony
requested changes
Mar 15, 2021
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_refering-to-a-parent-devfile-in-a-devfile.adoc
Outdated
Show resolved
Hide resolved
|
@jc-berger LGTM language-wise |
|
@maysunfaisal, thanks for the review. Please let me know if you think it's ready for the LGTM label. Doc review thought so! |
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
maysunfaisal
approved these changes
Mar 24, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, jc-berger, maysunfaisal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jc-berger
changed the title
|
New changes are detected. LGTM label has been removed. |
rkratky
reviewed
Mar 26, 2021
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
rkratky
reviewed
Mar 26, 2021
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
minor tweaks to the yaml more content and yaml changes restructured and cut content from attributes doc minor change to attributes doc more minor changes to grammar and word choice
rkratky
reviewed
Mar 30, 2021
docs/modules/user-guide/partials/proc_adding-attributes-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
…evfile.adoc Co-authored-by: Robert Krátký <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Jira #2557.
See related GitHub issues:
Tagging @rkratky, for your awareness.