added doc for how to develop with devfiles #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Deploying PR Preview... |
jc-berger
commented
Jan 5, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
jc-berger
commented
Jan 5, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
jc-berger
commented
Jan 5, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
reviewed
Jan 6, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
….adoc Co-authored-by: Brian Burt <[email protected]>
yangcao77
reviewed
Jan 7, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
yangcao77
reviewed
Jan 7, 2022
yangcao77
reviewed
Jan 7, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
yangcao77
approved these changes
Jan 10, 2022
missmesss
reviewed
Jan 12, 2022
missmesss
reviewed
Jan 12, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
|
@jc-berger The procedure looks amazing, thank you. I'm only adding a couple of suggestions. |
….adoc Co-authored-by: Olga Tikhomirova <[email protected]>
….adoc Co-authored-by: Olga Tikhomirova <[email protected]>
|
@rkratky please take a look and merge if you see fit, thanks! |
missmesss
approved these changes
Jan 12, 2022
|
@missmesss: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rkratky
requested changes
Jan 13, 2022
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_developing-with-devfiles.adoc
Outdated
Show resolved
Hide resolved
|
@rkratky thanks! Ready for your second look! |
rkratky
approved these changes
Jan 21, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, missmesss, rkratky, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes devfile/api#380
Fixes https://issues.redhat.com/browse/RHDEVDOCS-2869
Looking at #380, this PR does not address all 3 points, but it does provide "how to" instructions for how to develop a simple application by using devfiles.
Let me know if you think this is a good start for beginning "how to" documentation for devfiles.