chore (deps) : Update Controller runtime to latest available version v0.21.1-0.20250617162058-15c5d6129278
#1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…v0.21.1-0.20250617162058-15c5d6129278 - Update sigs.k8s.io/controller-runtime to latest available version - Update sigs.k8s.io/controller-tools to v0.18.0 - support for v1beta1 CRDs has been removed - Update Go version to 1.24 (required for controller runtime) Signed-off-by: Rohan Kumar <[email protected]>
Signed-off-by: Rohan Kumar <[email protected]>
… update Signed-off-by: Rohan Kumar <[email protected]>
After bumping go version, I started seeing this error in tests: ``` Error: test/v200/utils/common/test_utils.go:371:12: non-constant format string in call to (*testing.common).Fatalf Error: test/v200/utils/api/test_utils.go:186:13: non-constant format string in call to (*testing.common).Fatalf ``` It seems after Go 1.24, vet is flagging this case as invalid usage. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/bump-controller-runtime-post-0-21-0
branch
from
580a483 to
8d4841a
Compare
Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
v0.21.1-0.20250617162058-15c5d6129278ctx.WriteYAMLnow requires additionalheaderTextargument, I've added the content oflicense_header.txt. Let me know if we want to keep it without header.Signed-off-by: Rohan Kumar [email protected]
Related Issue(s)
This is related to a synk issue, We would like to update
apiextensions-apiserverdependency to >=v0.33.1. This also requires bumping controller-runtime to the latest version.Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
New testing and documentation issues can be opened under
devfile/api/issues.You can check the respective criteria below if either of the following is true:
If criteria is left unchecked please provide an explanation why.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Tests Performed
I ran the tests mentioned in CONTRIBUTING guide: