HTTP authentication #153
Merged
HTTP authentication #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Good catch on the test failure.
For the auth portion, I'll note my initial thoughts and why I chose to ignore them. We could avoid adding a new argument and lots of argument passing by parsing the auth information from the URL directly: (e.g. requests.get(..., auth(o.user, o.pass))). This is comparatively simpler and easier to maintain BUT is seems like it is deprecated in many places because of security concerns. So I feel like we shouldn't encourage that and this PR is good to go 🚢
|
Circle checks passed, github webhook seems broken for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates in this PR
Adds ability to specify a username and password for http authentication. This is useful for TMS requests behind a protected server. Closes #152
I also had to update an image in the test fixture. The version on NASA's server seemed to be slightly modified (as in a few intensity values per pixel). Visually, it still appears identical though. I verified that tests failed on master branch.
Next steps
@drewbo, once this looks good, I can create a new tag and push it to pypi. Then I'll need some help deploying the updated docs to the label-maker website.