fix(ext/node): fs.mkdtemp and fs.mkdtempSync compatibility
#30602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tango992
force-pushed
the
fix-node-fs-mkdtemp
branch
from
e960867 to
44dd3ed
Compare
|
Putting it to draft to spike on the directory suffix name generation |
Tango992
commented
Sep 5, 2025
Comment on lines
+632
to
+640
| fn temp_path_append_suffix(prefix: &str) -> String { | ||
| use rand::Rng; | ||
| use rand::distributions::Alphanumeric; | ||
| use rand::rngs::OsRng; | ||
|
|
||
| let suffix: String = | ||
| (0..6).map(|_| OsRng.sample(Alphanumeric) as char).collect(); | ||
| format!("{}{}", prefix, suffix) | ||
| } |
There was a problem hiding this comment.
Chose this approach instead of using the tempfile crate because it relies on fastrand, which is not cryptographically secure. Not that it matters that much, but this method aligns more closely with how libuv handles temp file suffixes https://github.com/nodejs/node/blob/591ba692bfe30408e6a67397e7d18bfa1b9c3561/deps/uv/src/win/fs.c#L1267-L1270
dsherret
approved these changes
Sep 5, 2025
Comment on lines
+632
to
+640
| fn temp_path_append_suffix(prefix: &str) -> String { | ||
| use rand::Rng; | ||
| use rand::distributions::Alphanumeric; | ||
| use rand::rngs::OsRng; | ||
|
|
||
| let suffix: String = | ||
| (0..6).map(|_| OsRng.sample(Alphanumeric) as char).collect(); | ||
| format!("{}{}", prefix, suffix) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.mkdtempandfs.mkdtempSyncnow acceptBufferandUint8Arraypath. The implementation has been moved to Rust, including directory suffix generation and directory creation.These changes allow the following tests to pass: