feat: allow disable hostname verification in TLS #30409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes denoland#28903 - Adds a new option `disableHostnameVerification` to `Deno.connectTls` and `Deno.startTls` to ignore DNS name mismatch errors from rustls server verifier. - Disable hostname verification in Node.js TLSSocket if `checkServerIdentity` is a no-op.
dsherret
reviewed
Aug 14, 2025
bartlomieju
reviewed
Aug 16, 2025
cli/tsc/dts/lib.deno_net.d.ts
Outdated
| * | ||
| * @default {false} | ||
| */ | ||
| disableHostnameVerification?: boolean; |
There was a problem hiding this comment.
Should we name it something like unsafelyDisableHostnameVerification? I think we should update the docstring too, to tell that this shouldn't be done by most users and when it might be useful.
There was a problem hiding this comment.
I was thinking this too. Btw, @littledivy remember to post these public api changes to the cli-public-api channel
There was a problem hiding this comment.
Renamed tounsafelyDisableHostnameVerification
Signed-off-by: Divy <[email protected]>
bartlomieju
reviewed
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28903
Closes #26190
unsafelyDisableHostnameVerificationtoDeno.connectTlsandDeno.startTlsto ignore DNS name mismatch errors from rustls server verifier.checkServerIdentityis a no-op.