feat(lsp): pull-based diagnostics #30325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13579.
Implements pull-based diagnostics and replaces the push diagnostics implementation to reuse this code. Pull diagnostics will be much faster in large monorepos because requests to each TS subproject will not be blocked on each other.
Also includes a big performance boost by batching
textDocument/didChangenotifications as much as possible before callingrefresh_dep_info(), which iterates and analyses every known module. Note that this notification didn't have any sort of cancellation, so the calls to that function piled up for each key press. Should be much faster for rapid sequences of changes in projects with a large module graph. d949618