Skip to content

fix(ext/node): use custom allocator for brotli #30277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

fix(ext/node): use custom allocator for brotli #30277

merged 3 commits into from
Aug 5, 2025

Conversation

littledivy
Copy link
Member

Fixes #30259

@0f-0b
Copy link
Contributor

0f-0b commented Aug 1, 2025

Is is possible to avoid brotli::ffi? It not only still causes linker errors, but also uses one more allocation per instance and requires unsafe.

@wavim
Copy link

wavim commented Aug 4, 2025

any updates? not an expert of rust so could only bump the thread
it breaks the frequently used express/compression middleware as im aware

@bartlomieju bartlomieju enabled auto-merge (squash) August 5, 2025 08:59
@bartlomieju bartlomieju merged commit 5b51410 into denoland:main Aug 5, 2025
18 checks passed
@ilbertt ilbertt mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Leak by using node:zlib with DENO 2.4.3
4 participants
@littledivy @0f-0b @wavim @bartlomieju