-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat(cli): reload environment variables with --watch
and --env-file
#30197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): reload environment variables with --watch
and --env-file
#30197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Would it be possible to add a test for this to ensure it works and continues to work in the future?
--watch
and --env-file
I think this is a duplicate of #29555 ? |
no it's different, you can take reference of the code changes |
--watch
and --env-file
--watch
and --env-file
Signed-off-by: Meet Dhanani <[email protected]>
Hello @dsherret, Could you please guide me with fixes the test cases of pipeline ci / test debug linux-aarch64 (pull_request)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This PR seems to be on the right track.
…e management - Added WatchEnvTracker to track and manage environment variables loaded from .env files. - Updated `resolve_flags_and_init` and `run_with_watch` functions to utilize the new tracker. - Enhanced error handling for loading environment variables from files.
Hello @dsherret, I have already requested the PR review after resolving all the comments. If there are any changes required, please let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
fix(cli/watch): Reload environment variables with --watch and --env-file