Skip to content

fix(compile): do not error including npm packages that don't match current system #30188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix(compile): do not error including npm packages that don't match current system #30188

merged 1 commit into from
Jul 24, 2025

Conversation

dsherret
Copy link
Member

Part of #30177

dsherret
dsherret commented Jul 24, 2025
View reviewed changes
cli/standalone/binary.rs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add a test for this, but I'm not sure the exact conditions that trigger this, so I gave up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair

@dsherret dsherret requested a review from bartlomieju July 24, 2025 12:00
@dsherret dsherret mentioned this pull request Jul 24, 2025
Merged
@dsherret dsherret merged commit 4850b3b into denoland:main Jul 24, 2025
34 of 35 checks passed
@dsherret dsherret deleted the fix_compile_ignore_npm_pkgs_not_on_system branch July 24, 2025 20:11
dsherret added a commit that referenced this pull request Jul 24, 2025
@dsherret
fix(compile): do not include managed npm deps when graph does not hav…
0f0c678 
…e any npm pkgs (#30189)

Closes #30177 (along with
#30188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju